Create CommentPlus.js #1200
Create CommentPlus.js #1200
Conversation
|
Why not just add the blocks to the existing Comment Blocks extension? |
|
Thats not supposed to happen |
Yeah I could but I just created my own. |
There was a problem hiding this comment.
This extension is relatively pointless; I don't see the point in over half of these blocks when the couplers extension exists and does a similar job.
Furthermore, as per the contributing guidelines, you shouldn't submit extensions that are similar to existing ones, and this is an adaptation of an extension on the gallery.
Consider adding the blocks you think are essential to the existing extension as others have suggested.
All problems has been fixed. |
Fixed |
| }, | ||
| }, | ||
| { | ||
| opcode: "commentCPlusPlus", |
There was a problem hiding this comment.
Can you specify what the point of a double-branch comment block is? As stated previously, the second branch doesn't even run because of how you return the function.
There was a problem hiding this comment.
Yeah, that block is just pointless, but I created that for the blocks put in first branch would work (like previous ones) and next branch wouldn't work. If you can, please write and comment me the code where both branches would work in the same block.
There was a problem hiding this comment.
I'm not going to write this extension for you as a block like that shouldn't exist to begin with
| // no-op | ||
| } | ||
|
|
||
| commentReporterPlus(args) { |
There was a problem hiding this comment.
This still doesn't return anything; reporters cannot return nothing.
| return args.COLOR; | ||
| } | ||
|
|
||
| commentBooleanP7(args) { |
There was a problem hiding this comment.
I don't understand where or why you'd need a color input inside of a boolean.
There was a problem hiding this comment.
Yeah you're right because reporters could do that. You can say, I just created it for Boolean shaped block. If you say, I would remove Booleans which had colors strings.
There was a problem hiding this comment.
In an ideal world you'd just remove all of the color blocks
| // no-op | ||
| } | ||
|
|
||
| commentCap() { |
There was a problem hiding this comment.
Remove your unused functions
| // no-op | ||
| } | ||
|
|
||
| commentReporterPlus(args) { |
There was a problem hiding this comment.
Please don't mark issues as resolved unless they are actually resolved. This still does not return anything. That is a bug. Please fix it
| return args.INPUT; | ||
| } | ||
|
|
||
| commentBooleanPlus(args) { |
There was a problem hiding this comment.
Please don't mark issues as resolved unless they are actually resolved. This still does not return anything. That is a bug. Please fix it
| return args.COLOR; | ||
| } | ||
|
|
||
| commentBooleanP7(args) { |
There was a problem hiding this comment.
In an ideal world you'd just remove all of the color blocks
|
Please do not mark conversations as resolved if they are not resolved. |
|
sorry to have to say no, but I don't see much in here that is really an upgrade beyond the existing comment extension, and we definitely don't need two competing comment extensions. if there's something innovative here I'm missing, please submit a pull request to add it to the existing extension extension review is currently months behind -- very sorry for the delay getting to that decision |
Well I've created a extension called Comment Plus. Actually it's a developed version of Comment Blocks which was made by LilyMakesThings.